Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis #10

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

travis #10

wants to merge 7 commits into from

Conversation

graingert
Copy link
Collaborator

No description provided.

Thomas Grainger added 2 commits July 12, 2017 21:11
@graingert
Copy link
Collaborator Author

@PeterJCLaw I've hacked the tests into passing, but at what cost?

There's a skipped test, and some of the images have changed.

Most of the images have changed how the text is rendered: pay attention to the letter 'a'

All of the azteccode and datamatrix barcodes have changed significantly, why? I don't know.

@PeterJCLaw
Copy link
Contributor

Hrm, if the visuals have changed I wonder if there's some dependent font we're missing?

@PeterJCLaw
Copy link
Contributor

It might also be interesting to rewind the history to see if there was a point when they did pass.

@graingert
Copy link
Collaborator Author

Edit, I got the tests passing locally, but it looks like it's different on Travis. Probably fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants